Optimize reload docs when performing bulk writes #3942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test snippet import time
import fiftyone as fo
ds = fo.zoo.load_zoo_dataset('coco-2017', splits='validation')
ds.clear_sample_field("metadata")
_ = [s for s in ds.iter_samples()]
t1 = time.time()
ds.compute_metadata()
t2 = time.time()
print(t2-t1)Timings
The speedup gets more pronounced as number of samples gets bigger though, so this change is definitely worth it |
swheaton
reviewed
Dec 19, 2023
| @@ -7586,7 +7588,7 @@ def _add_collection_with_new_ids( | |||
| for old_id, new_id in zip(old_ids, new_ids) | |||
| ] | |||
|
|
|||
| dataset._bulk_write(ops, frames=True) | |||
| dataset._bulk_write(ops, ids=[], frames=True) | |||
There was a problem hiding this comment.
Nice; they're new samples so we don't need to reload any singleton samples
swheaton
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing
dataset._bulk_write(), only reload the docs that were involved in the mutations, if known.