Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for configuring whether run cleanup happens #3957

Closed
wants to merge 2 commits into from

Conversation

brimoor
Copy link
Contributor

@brimoor brimoor commented Dec 30, 2023

No change in default behavior; just adds support for a new syntax:

run.register_run(dataset, key, overwrite=True, cleanup=False)

which overwrites an existing run without running the existing run's cleanup() method.

@brimoor brimoor added the enhancement Code enhancement label Dec 30, 2023
@brimoor brimoor requested a review from a team December 30, 2023 18:18
@brimoor brimoor self-assigned this Dec 30, 2023
Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8c018ed) 15.85% compared to head (b8464eb) 15.85%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3957   +/-   ##
========================================
  Coverage    15.85%   15.85%           
========================================
  Files          731      731           
  Lines        81886    81886           
  Branches      1093     1093           
========================================
  Hits         12987    12987           
  Misses       68899    68899           
Flag Coverage Δ
app 15.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brimoor brimoor changed the base branch from develop to release/v0.23.3 January 8, 2024 04:13
@brimoor brimoor changed the base branch from release/v0.23.3 to develop January 8, 2024 04:13
@brimoor
Copy link
Contributor Author

brimoor commented Jan 8, 2024

Merging into release/v0.23.3 instead in #3978

@brimoor brimoor closed this Jan 8, 2024
@brimoor brimoor deleted the run-cleanup-flag branch January 8, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Code enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant