Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sort by similarity for datasets with a color scheme #3958

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

benjaminpkane
Copy link
Contributor

@benjaminpkane benjaminpkane commented Jan 2, 2024

The /sort route is currently used only to ensure a dist_field is correctly populated if the parameter is provided. Before routing updates, this meant a new dataset scheme was needed in the response. Omitting the response prevents serialization errors when a dataset has a color_scheme

@benjaminpkane benjaminpkane added bug Bug fixes app Issues related to App features labels Jan 2, 2024
@benjaminpkane benjaminpkane self-assigned this Jan 2, 2024
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7eaeee9) 15.86% compared to head (b856f15) 15.86%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release/v0.23.3    #3958   +/-   ##
================================================
  Coverage            15.86%   15.86%           
================================================
  Files                  731      731           
  Lines                81853    81853           
  Branches              1093     1093           
================================================
  Hits                 12987    12987           
  Misses               68866    68866           
Flag Coverage Δ
app 15.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from release/v0.23.3 to develop January 8, 2024 04:08
@sashankaryal sashankaryal requested a review from a team January 9, 2024 17:44
Copy link
Contributor

@sashankaryal sashankaryal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good 🐐

@benjaminpkane benjaminpkane merged commit f902efb into develop Jan 10, 2024
9 checks passed
@benjaminpkane benjaminpkane deleted the bug/sort-response branch January 10, 2024 19:44
benjaminpkane added a commit that referenced this pull request Jan 12, 2024
benjaminpkane added a commit that referenced this pull request Jan 12, 2024
brimoor pushed a commit that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Issues related to App features bug Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants