Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release updates #3972

Merged
merged 5 commits into from
Jan 5, 2024
Merged

Release updates #3972

merged 5 commits into from
Jan 5, 2024

Conversation

benjaminpkane
Copy link
Contributor

@benjaminpkane benjaminpkane commented Jan 5, 2024

Adds #3960, #3926, and #3851 to v0.23.3

@benjaminpkane benjaminpkane self-assigned this Jan 5, 2024
brimoor
brimoor previously approved these changes Jan 5, 2024
Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 70 lines in your changes are missing coverage. Please review.

Comparison is base (44063a9) 15.84% compared to head (4c3bca3) 15.85%.

Files Patch % Lines
...ore/src/components/Schema/SchemaSelectControls.tsx 0.00% 45 Missing ⚠️
...core/src/plugins/SchemaIO/utils/generate-schema.ts 0.00% 15 Missing ⚠️
...e/src/plugins/SchemaIO/components/InferredView.tsx 0.00% 7 Missing ⚠️
app/packages/core/src/utils/links.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release/v0.23.3    #3972   +/-   ##
================================================
  Coverage            15.84%   15.85%           
================================================
  Files                  731      731           
  Lines                81907    81915    +8     
  Branches              1093     1093           
================================================
+ Hits                 12980    12988    +8     
  Misses               68927    68927           
Flag Coverage Δ
app 15.85% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

brimoor
brimoor previously approved these changes Jan 5, 2024
@benjaminpkane
Copy link
Contributor Author

@manivoxel51 any idea why e2e is failing?

@manivoxel51
Copy link
Contributor

@manivoxel51 any idea why e2e is failing?

I can take a look - not sure

Copy link
Contributor

@manivoxel51 manivoxel51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🍨

@benjaminpkane benjaminpkane merged commit ac6b0fd into release/v0.23.3 Jan 5, 2024
15 checks passed
@benjaminpkane benjaminpkane deleted the release-updates branch January 5, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants