Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

back to 1.1.0 development #5010

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

findtopher
Copy link
Member

@findtopher findtopher commented Oct 30, 2024

What changes are proposed in this pull request?

We have pushed the release back by a week, putting develop back to v1.1.0 until the new release branches are thrown

Summary by CodeRabbit

  • Chores
    • Updated the version number from "1.2.0" to "1.1.0" in the project setup.

@findtopher findtopher requested a review from a team October 30, 2024 19:34
Copy link
Contributor

coderabbitai bot commented Oct 30, 2024

Walkthrough

The changes in this pull request primarily involve updating the version number in the setup.py file for the FiftyOne project. The version has been changed from "1.2.0" to "1.1.0". This modification affects the VERSION variable and the get_version() function, which checks the RELEASE_VERSION environment variable against the new version. If there is a mismatch, a ValueError is raised. No other significant changes were made to the logic or configurations.

Changes

File Change Summary
setup.py Updated VERSION from "1.2.0" to "1.1.0". Adjusted get_version() function to reflect this change.

Possibly related PRs

Suggested reviewers

  • afoley587
  • benjaminpkane

🐇 In the garden, I hop with glee,
A version change, oh joy for me!
From "1.2" to "1.1" we go,
A little tweak, just so you know.
With every hop, our code stays bright,
In the world of software, we take flight! 🌼


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 430c3f7 and 31e1eb4.

📒 Files selected for processing (1)
  • setup.py (1 hunks)
🔇 Additional comments (3)
setup.py (3)

Line range hint 29-93: Verify dependency compatibility with v1.1.0

While the dependencies remain unchanged, please ensure all listed package versions are compatible with v1.1.0, particularly the internal packages:

  • fiftyone-brain>=0.17.0,<0.18
  • fiftyone-db>=0.4,<2.0
  • voxel51-eta>=0.13.0,<0.14
#!/bin/bash
# Check git history for any dependency changes between v1.1.0 and v1.2.0
git log --oneline -p setup.py | grep -A 5 -B 5 "INSTALL_REQUIRES"

Line range hint 16-93: Update release documentation

Since this is a version reversion, ensure that release notes, changelog, and other documentation are updated to reflect this change.

#!/bin/bash
# Check for changelog and release note files
fd -g 'CHANGELOG*' -g 'RELEASE*'

16-16: Version change aligns with PR objective.

The version update from "1.2.0" to "1.1.0" correctly implements the intended reversion for development.

Let's verify version consistency across the project:


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant