New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove/move invalid factset files #78

Closed

glennsarti opened this issue Mar 26, 2018 · 1 comment

Contributor

glennsarti commented Mar 26, 2018

There are quite a few factset files which are in the wrong directory, for example https://github.com/camptocamp/facterdb/blob/master/facts/1.6/sles-12-x86_64.facts is in 1.6 but has a facter version of "1.7.6".

These should removed or moved and tests added to ensure it doesn't happen again.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#78) Add tests for facter version

cde701c

Previously many factset files were in the wrong directory which made maintenance
and debugging difficult.  This commit adds tests to ensure that the factset
files are indeed JSON parsable and that the facter version in the file matches
the directory it is located in.

This test is maked as skipped until all of the bad factset files can be changed.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#78) Move SLES 12 facts into correct directory

bfe4d51

Previously the factset files for SLES 12 were in the wrong location.  This
commit moves the SLES factset files

From:
  1.6 to 1.7
  1.7 to 2.0
  2.0 to 2.1
  2.1 to 2.2
  2.3 to 2.4
  2.4 to 1.6

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#78) Move PCS 6 fact set to correct directory

24ee034

Previously the PC6 factset file was placed in the 2.4 directory however the
facter version is 3.6.  This commit moves the file to the correct location.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#78) Remove incorrect factset for Amazon 2017, facter 2.5

ec860d0

The factset for Amazon 2017 in the 2.5 directory has a facter version of 1.6.
Looking at the factset in the 1.6 directory, this is just a copy of that set.
This commit removes the incorrect and redundant factset file.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#78) Enforce default factset file directory layout test

826afb7

Previously the test for factset file directory was created but skipped while the
factset files were fixed.  Now that the files have been fixed, this test
can be enforced.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#78) Add tests for facter version

9cd76a8

Previously many factset files were in the wrong directory which made maintenance
and debugging difficult.  This commit adds tests to ensure that the factset
files are indeed JSON parsable and that the facter version in the file matches
the directory it is located in.

This test is maked as skipped until all of the bad factset files can be changed.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#78) Move SLES 12 facts into correct directory

f011274

Previously the factset files for SLES 12 were in the wrong location.  This
commit moves the SLES factset files

From:
  1.6 to 1.7
  1.7 to 2.0
  2.0 to 2.1
  2.1 to 2.2
  2.3 to 2.4
  2.4 to 1.6

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#78) Move PCS 6 fact set to correct directory

0f41b42

Previously the PC6 factset file was placed in the 2.4 directory however the
facter version is 3.6.  This commit moves the file to the correct location.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#78) Remove incorrect factset for Amazon 2017, facter 2.5

67d638d

The factset for Amazon 2017 in the 2.5 directory has a facter version of 1.6.
Looking at the factset in the 1.6 directory, this is just a copy of that set.
This commit removes the incorrect and redundant factset file.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#78) Enforce default factset file directory layout test

a17206e

Previously the test for factset file directory was created but skipped while the
factset files were fixed.  Now that the files have been fixed, this test
can be enforced.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#78) Add tests for facter version

6b14ad5

Previously many factset files were in the wrong directory which made maintenance
and debugging difficult.  This commit adds tests to ensure that the factset
files are indeed JSON parsable and that the facter version in the file matches
the directory it is located in.

This test is maked as skipped until all of the bad factset files can be changed.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#78) Move SLES 12 facts into correct directory

907a5e4

Previously the factset files for SLES 12 were in the wrong location.  This
commit moves the SLES factset files

From:
  1.6 to 1.7
  1.7 to 2.0
  2.0 to 2.1
  2.1 to 2.2
  2.3 to 2.4
  2.4 to 1.6

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#78) Move PCS 6 fact set to correct directory

e6868a0

Previously the PC6 factset file was placed in the 2.4 directory however the
facter version is 3.6.  This commit moves the file to the correct location.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#78) Remove incorrect factset for Amazon 2017, facter 2.5

2ad515c

The factset for Amazon 2017 in the 2.5 directory has a facter version of 1.6.
Looking at the factset in the 1.6 directory, this is just a copy of that set.
This commit removes the incorrect and redundant factset file.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#78) Enforce default factset file directory layout test

b0c6e9e

Previously the test for factset file directory was created but skipped while the
factset files were fixed.  Now that the files have been fixed, this test
can be enforced.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#78) Add tests for facter version

53ca156

Previously many factset files were in the wrong directory which made maintenance
and debugging difficult.  This commit adds tests to ensure that the factset
files are indeed JSON parsable and that the facter version in the file matches
the directory it is located in.

This test is maked as skipped until all of the bad factset files can be changed.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#78) Move SLES 12 facts into correct directory

Previously the factset files for SLES 12 were in the wrong location.  This
commit moves the SLES factset files

From:
  1.6 to 1.7
  1.7 to 2.0
  2.0 to 2.1
  2.1 to 2.2
  2.3 to 2.4
  2.4 to 1.6

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#78) Move PCS 6 fact set to correct directory

d959368

Previously the PC6 factset file was placed in the 2.4 directory however the
facter version is 3.6.  This commit moves the file to the correct location.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#78) Remove incorrect factset for Amazon 2017, facter 2.5

5ed45b0

The factset for Amazon 2017 in the 2.5 directory has a facter version of 1.6.
Looking at the factset in the 1.6 directory, this is just a copy of that set.
This commit removes the incorrect and redundant factset file.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#78) Enforce default factset file directory layout test

7eb94b1

Previously the test for factset file directory was created but skipped while the
factset files were fixed.  Now that the files have been fixed, this test
can be enforced.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#78) Add tests for facter version

8db07f0

Previously many factset files were in the wrong directory which made maintenance
and debugging difficult.  This commit adds tests to ensure that the factset
files are indeed JSON parsable and that the facter version in the file matches
the directory it is located in.

This test is maked as skipped until all of the bad factset files can be changed.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#78) Move SLES 12 facts into correct directory

aadbd4c

Previously the factset files for SLES 12 were in the wrong location.  This
commit moves the SLES factset files

From:
  1.6 to 1.7
  1.7 to 2.0
  2.0 to 2.1
  2.1 to 2.2
  2.3 to 2.4
  2.4 to 1.6

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#78) Move PCS 6 fact set to correct directory

dbe0055

Previously the PC6 factset file was placed in the 2.4 directory however the
facter version is 3.6.  This commit moves the file to the correct location.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#78) Remove incorrect factset for Amazon 2017, facter 2.5

172b45d

The factset for Amazon 2017 in the 2.5 directory has a facter version of 1.6.
Looking at the factset in the 1.6 directory, this is just a copy of that set.
This commit removes the incorrect and redundant factset file.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#78) Enforce default factset file directory layout test

c8d48b3

Previously the test for factset file directory was created but skipped while the
factset files were fixed.  Now that the files have been fixed, this test
can be enforced.

rodjek pushed a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#78) Add tests for facter version

a659972

Previously many factset files were in the wrong directory which made maintenance
and debugging difficult.  This commit adds tests to ensure that the factset
files are indeed JSON parsable and that the facter version in the file matches
the directory it is located in.

This test is maked as skipped until all of the bad factset files can be changed.

rodjek pushed a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#78) Move SLES 12 facts into correct directory

940dacf

Previously the factset files for SLES 12 were in the wrong location.  This
commit moves the SLES factset files

From:
  1.6 to 1.7
  1.7 to 2.0
  2.0 to 2.1
  2.1 to 2.2
  2.3 to 2.4
  2.4 to 1.6

rodjek pushed a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#78) Move PCS 6 fact set to correct directory

340010a

Previously the PC6 factset file was placed in the 2.4 directory however the
facter version is 3.6.  This commit moves the file to the correct location.

rodjek pushed a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#78) Remove incorrect factset for Amazon 2017, facter 2.5

e4a5ab4

The factset for Amazon 2017 in the 2.5 directory has a facter version of 1.6.
Looking at the factset in the 1.6 directory, this is just a copy of that set.
This commit removes the incorrect and redundant factset file.

rodjek pushed a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#78) Enforce default factset file directory layout test

025c17d

Previously the test for factset file directory was created but skipped while the
factset files were fixed.  Now that the files have been fixed, this test
can be enforced.

rodjek added a commit that referenced this issue


          Merge pull request #79 from glennsarti/add-more-factset-tests

644d899

(#77)(#78)  Add default factset tests and fix failures

Member

rodjek commented Jul 15, 2019

Fixed by #79

rodjek closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment