facts_spec: Pathname class is missing #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
according to travis this breaks down with ruby 2.3. is 2.3 still intended to be supported onwards? |
|
Could you please rebase since #166 as been merged |
In debian's CI environment, running the spec tests fails with the
following error:
RUBYLIB=. GEM_PATH=/<<PKGBUILDDIR>>/debian/facterdb/usr/share/rubygems-integration/all:/<<PKGBUILDDIR>>/debian/.debhelper/generated/_source/home/.local/share/gem/ruby/2.7.0:/var/lib/gems/2.7.0:/usr/local/lib/ruby/gems/2.7.0:/usr/lib/ruby/gems/2.7.0:/usr/lib/x86_64-linux-gnu/ruby/gems/2.7.0:/usr/share/rubygems-integration/2.7.0:/usr/share/rubygems-integration/all:/usr/lib/x86_64-linux-gnu/rubygems-integration/2.7.0 ruby2.7 -S rake -f debian/ruby-tests.rake
/usr/bin/ruby2.7 -I/usr/share/rubygems-integration/all/gems/rspec-support-3.9.3/lib:/usr/share/rubygems-integration/all/gems/rspec-core-3.9.2/lib /usr/share/rubygems-integration/all/gems/rspec-core-3.9.2/exe/rspec --pattern ./spec/\*\*/\*_spec.rb --format documentation
An error occurred while loading ./spec/facts_spec.rb.
Failure/Error: project_dir = Pathname.new(__dir__).parent
NameError:
uninitialized constant Pathname
# ./spec/facts_spec.rb:84:in `block in <top (required)>'
# ./spec/facts_spec.rb:42:in `<top (required)>'
Finished in 0.00003 seconds (files took 0.16545 seconds to load)
0 examples, 0 failures, 1 error occurred outside of examples
To fix this we simply need to make sure that the 'pathname' stdlib is
"require"d at the top of the file.
|
@mcanevet I've rebased on top of master and foce-pushed on my side. the new check results are in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In debian's CI environment, running the spec tests fails with the
following error:
To fix this we simply need to make sure that the 'pathname' stdlib is
"require"d at the top of the file.