Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for augeas.version fact #319

Merged
merged 4 commits into from
May 18, 2024
Merged

Add test for augeas.version fact #319

merged 4 commits into from
May 18, 2024

Conversation

bastelfreak
Copy link
Member

No description provided.

@bastelfreak bastelfreak self-assigned this May 14, 2024
ekohl
ekohl reviewed May 14, 2024
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should disable Style/IfUnlessModifier since we disable line lengths. In this case it would absolutely be harder to read.

@bastelfreak
Copy link
Member Author

@ekohl updated it

@bastelfreak
Copy link
Member Author

it probably makes sense to first drop facter 3 🤔

@bastelfreak bastelfreak force-pushed the cleanup6 branch 5 times, most recently from c3a0058 to fd7ca8d Compare May 18, 2024 17:22
@bastelfreak
Copy link
Member Author

also contains #349

@bastelfreak bastelfreak merged commit 584ab02 into voxpupuli:master May 18, 2024
7 checks passed
@bastelfreak bastelfreak deleted the cleanup6 branch May 18, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

@TheMeier TheMeier TheMeier approved these changes

Assignees

@bastelfreak bastelfreak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bastelfreak @ekohl @TheMeier