Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional facts #53

Closed
wants to merge 1 commit into from
Closed

Conversation

b4ldr
Copy link
Member

@b4ldr b4ldr commented Sep 5, 2017

Hi i took a look at the get_facts script and added a few fixes as it didn't seem to work. I have also created a new script called generate_facts.sh which just spins up each machine one at a time as i dont have the disk space to store all vms. I also changed the logic so that if a file already exists it is not updated which helps keep the git commit smaller. Other then that all fact files where created by running

cd facts
./generate_facts.sh

@b4ldr b4ldr mentioned this pull request Sep 5, 2017
@coveralls
Copy link

coveralls commented Sep 5, 2017

Coverage Status

Coverage remained the same at 73.529% when pulling 54fdfa0 on b4ldr:freebsd_facts into 9c3f815 on camptocamp:master.

"netmask": "255.255.255.0",
"network_enp0s3": "10.0.2.0",
"network_lo": "127.0.0.0",
"operatingsystemrelease": "stretch/sid",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that Debian 9 image was not fully updated to a 9.x release.

@mmoll
Copy link
Contributor

mmoll commented Sep 9, 2017

see GH-52 for problems with Debian/stretch facts.

@b4ldr
Copy link
Member Author

b4ldr commented Sep 11, 2017

@mmoll i have updated the vagrant image used for debian-9 and believe that the get_facts script is now producing correct facts

@coveralls
Copy link

coveralls commented Sep 11, 2017

Coverage Status

Coverage remained the same at 73.529% when pulling dc1bf4b on b4ldr:freebsd_facts into 9c3f815 on camptocamp:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 73.529% when pulling dc1bf4b on b4ldr:freebsd_facts into 9c3f815 on camptocamp:master.

@coveralls
Copy link

coveralls commented Sep 11, 2017

Coverage Status

Coverage remained the same at 73.529% when pulling dc1bf4b on b4ldr:freebsd_facts into 9c3f815 on camptocamp:master.

@mmoll
Copy link
Contributor

mmoll commented Sep 11, 2017

@b4ldr this is looking good 👍

@mcanevet
Copy link
Member

@b4ldr please remove facts/.Vagrantfile.swp from your commit

@b4ldr
Copy link
Member Author

b4ldr commented Sep 11, 2017

@mcanevet corrected, also updated the gitignore file

@coveralls
Copy link

coveralls commented Sep 11, 2017

Coverage Status

Coverage remained the same at 73.529% when pulling eb5cd10 on b4ldr:freebsd_facts into 9c3f815 on camptocamp:master.

@mmoll
Copy link
Contributor

mmoll commented Sep 20, 2017

this needs a rebase now

@b4ldr
Copy link
Member Author

b4ldr commented Sep 20, 2017

rebased

@coveralls
Copy link

coveralls commented Sep 20, 2017

Coverage Status

Coverage remained the same at 73.529% when pulling 45ffc77 on b4ldr:freebsd_facts into cb5266f on camptocamp:master.

@b4ldr
Copy link
Member Author

b4ldr commented Sep 26, 2017

is anything holding this back?

@mcanevet
Copy link
Member

@b4ldr please split this PR in different commit in case we have to revert one part.
Don't mix scripts and fact changes in the same commit.

remove vagrant files
@b4ldr
Copy link
Member Author

b4ldr commented Sep 27, 2017

ok i have split out the vagrant files into #59, if you accept that pull then you can generate this pull request you self by running ./facts/generate_facts.sh

@coveralls
Copy link

coveralls commented Sep 27, 2017

Coverage Status

Coverage remained the same at 73.529% when pulling 9a61548 on b4ldr:freebsd_facts into cb5266f on camptocamp:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 73.529% when pulling 9a61548 on b4ldr:freebsd_facts into cb5266f on camptocamp:master.

@b4ldr b4ldr closed this Nov 30, 2017
@b4ldr b4ldr deleted the freebsd_facts branch December 6, 2017 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants