-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add additional facts #53
Conversation
"netmask": "255.255.255.0", | ||
"network_enp0s3": "10.0.2.0", | ||
"network_lo": "127.0.0.0", | ||
"operatingsystemrelease": "stretch/sid", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that Debian 9 image was not fully updated to a 9.x release.
see GH-52 for problems with Debian/stretch facts. |
54fdfa0
to
dc1bf4b
Compare
@mmoll i have updated the vagrant image used for debian-9 and believe that the get_facts script is now producing correct facts |
2 similar comments
@b4ldr this is looking good 👍 |
@b4ldr please remove |
dc1bf4b
to
eb5cd10
Compare
@mcanevet corrected, also updated the gitignore file |
this needs a rebase now |
eb5cd10
to
45ffc77
Compare
rebased |
is anything holding this back? |
@b4ldr please split this PR in different commit in case we have to revert one part. |
remove vagrant files
45ffc77
to
9a61548
Compare
ok i have split out the vagrant files into #59, if you accept that pull then you can generate this pull request you self by running |
Hi i took a look at the get_facts script and added a few fixes as it didn't seem to work. I have also created a new script called
generate_facts.sh
which just spins up each machine one at a time as i dont have the disk space to store all vms. I also changed the logic so that if a file already exists it is not updated which helps keep the git commit smaller. Other then that all fact files where created by running