Update Fedora facts #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added fact file for Fedora 28. * Fixed incorrect facter version in Fedora 26 fact file.
|
facts/2.5/fedora-28-x86_64.facts broke the spec tests as its not a valid JSON file. |
This was referenced Sep 18, 2018
|
@baurmatt Sorry about that, I thought I ran the file through json-lint before I submitted it. |
|
@blackknight36 No worries! :) I've fixed it in #93 and also patched the Vagrantfile and get_facts.sh file for Fedora 28 support. It probably wasn't detected by the CI because it was already broken due to some unrelated issue. |
|
Thanks. On a related note, Fedora 29 is just around the corner. :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These facts were pulled from a live server running Fedora 28 x86_64.