Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add faraday-retry to release gem group #823

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

bastelfreak
Copy link
Member

This is an optional requirement for the changelog generator. GCG throws a warning when the gem is missing. Test PR: voxpupuli/puppet-example#31

This is an optional requirement for the changelog generator. GCG throws
a warning when the gem is missing.
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not happy about it, but I think it's the least of 2 evils now. Might be good to make GHCG depend on faraday-retry, but this could be merged as a stop gap solution.

@bastelfreak
Copy link
Member Author

@chelnak worked on a replacement for GCG and I think Puppet already uses it. Maybe that's a good long term solution.

@bastelfreak bastelfreak merged commit 0fb34ec into voxpupuli:master Apr 18, 2023
@bastelfreak bastelfreak deleted the faraday branch April 18, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants