Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modulesync 4.0.0 #78

Merged
merged 3 commits into from
Nov 27, 2020
Merged

modulesync 4.0.0 #78

merged 3 commits into from
Nov 27, 2020

Conversation

bastelfreak
Copy link
Member

modulesync 3.2.0

@bastelfreak bastelfreak force-pushed the modulesync branch 4 times, most recently from 8c2ba96 to b4f434f Compare November 16, 2020 10:51
@ekohl ekohl mentioned this pull request Nov 16, 2020
Merged
ekohl
ekohl reviewed Nov 16, 2020
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
ekohl
ekohl reviewed Nov 16, 2020
View reviewed changes
.sync.yml Show resolved Hide resolved
@ekohl ekohl force-pushed the modulesync branch 3 times, most recently from d783cd1 to d7771c1 Compare November 16, 2020 21:01
@ekohl
Copy link
Member

ekohl commented Nov 16, 2020

  • Fedora 32 on Puppet 6 fails because it can't install epel-release
  • F32 on Puppet 5 because that's unavailable
  • F33 because beaker-hostgenerator doesn't support it
  • EL8 can't install perl-TAP-Harness-Env

@ekohl
Copy link
Member

ekohl commented Nov 16, 2020

As a test I pushed a commit that drops Puppet 5. I expect acceptance tests to drop it now.

@ekohl ekohl force-pushed the modulesync branch 2 times, most recently from 460b67d to 62612fd Compare November 17, 2020 00:05
@ekohl ekohl mentioned this pull request Nov 17, 2020
Merged
7 tasks
bastelfreak
bastelfreak commented Nov 17, 2020
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
ekohl
ekohl requested changes Nov 25, 2020
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an update now.

ekohl
ekohl requested changes Nov 26, 2020
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F32 on Puppet 5 because that's unavailable (expected)
F33 because beaker-hostgenerator doesn't support it (expected)
EL8 can't install perl-TAP-Harness-Env (previously untested)

The last one needs a fix.

@ekohl ekohl changed the title modulesync 3.2.0 modulesync 4.0.0 Nov 26, 2020
@ekohl
Copy link
Member

ekohl commented Nov 27, 2020

Looks like that broke the unit tests.

@bastelfreak bastelfreak force-pushed the modulesync branch 2 times, most recently from 3eeb198 to 8d8ab2e Compare November 27, 2020 12:16
@bastelfreak bastelfreak mentioned this pull request Nov 27, 2020
Merged
ekohl
ekohl approved these changes Nov 27, 2020
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be fine with merging this if it only fails on F32 + P5 and F33.

@ekohl ekohl merged commit 6e6eb55 into master Nov 27, 2020
@ekohl ekohl deleted the modulesync branch November 27, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
modulesync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastelfreak @ekohl