Prevent 'false' from showing up in the console report #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this, when viewing the report in the console after diffing to catalog files, the word "false" would show up right next to the number of "Nodes with the most changes by differences". For example, note the errant "false" at the end of this: ``` -------------------------------------------------------------------------------- 1 out of 1 nodes changed. 0.34% -------------------------------------------------------------------------------- Nodes with the most changes by percent changed: 1. foo.bar.net-production 0.34% Nodes with the most changes by differences: 1. foo.bar.net-some_feature 8false ``` This was due to a Ruby `.key?` check inside a string interpolation of `nodes[:puppet_ouput]`, which when ":pull_output" was not a key in the `nodes` hash evaluated to `false`. And since `false` was inside the string interpolation, it got printed to the console. This fixes that by switching to the "x if condition y" format of conditional logic, which hides the output of the `.key?` check. After this commit, the console output does not contain the word "false". ``` -------------------------------------------------------------------------------- 1 out of 1 nodes changed. 0.34% -------------------------------------------------------------------------------- Nodes with the most changes by percent changed: 1. foo.bar.net-production 0.34% Nodes with the most changes by differences: 1. foo.bar.net-some_feature 8 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, when viewing the report in the console after diffing two
catalog files, the word "false" would show up right next to the number
of "Nodes with the most changes by differences".
For example, note the errant "false" at the end of this:
This was due to a Ruby
.key?check inside a string interpolation ofnodes[:puppet_ouput], which when ":pull_output" was not a key in thenodeshash evaluated tofalse. And sincefalsewas inside thestring interpolation, it got printed to the console.
This fixes that by switching to the "x if condition y" format of
conditional logic, which hides the output of the
.key?check.After this commit, the console output does not contain the word "false".