comparer: exit earily if old/new contents are empty #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b4ldr
approved these changes
Jun 8, 2022
Previously we called `validate_encoding()` to force the old/new strings to be UTF8. Afterwards we exit if one (or both) of the strings are `nil`. If they are actuall `nil`, `validate_encoding()` will fail. Hence it makes sense to move the return statement above the `validate_encoding()` calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we called
validate_encoding()to force the old/new stringsto be UTF8. Afterwards we exit if one (or both) of the strings are
nil. If they are actuallnil,validate_encoding()will fail.Hence it makes sense to move the return statement above the
validate_encoding()calls.