Support custom TLS certificates for old Puppetserver #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
commented
Jun 14, 2022
| @@ -97,14 +97,14 @@ def compile_catalog(node_name, server, certless) | |||
| end | |||
|
|
|||
| uri = URI("https://#{server}:#{port}#{endpoint}") | |||
| Puppet.debug("Connecting to server: #{uri}") | |||
There was a problem hiding this comment.
I don't think that this debug statement is required. The http client itself will log this at debug level already.
bastelfreak
commented
Jun 14, 2022
| end | ||
| raise "HTTP request to PuppetDB failed with: HTTP #{ret.code} - #{ret.reason}" unless ret.success? | ||
| raise "HTTP request to Puppetserver #{server} failed with: HTTP #{ret.code} - #{ret.reason}" unless ret.success? |
There was a problem hiding this comment.
this was a typo previously. the request was always going to the puppetserver, never puppetdb
evgeni
reviewed
Jun 14, 2022
sebastianrakel
approved these changes
Jul 20, 2022
evgeni
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues