add bindaddress option

[jhunt-steds]

Pull Request (PR) description

Add the bindaddress configuration option to chrony.conf.

This will allow users to specify an IP address on an interface on which chronyd should listen.

This Pull Request (PR) fixes the following issues

n/a

[jhunt-steds]

I realize the integration tests are failing for CentOS. I believe they are actually failing currently on your existing master branch as well (despite the passing badge); when I made a trivial change to README.md in my fork and had it run the test suite, it failed with the exact same errors this branch does. You can see these results in the details linked from https://github.com/jhunt-steds/puppet-chrony/pull/2/checks .

In case this is useful information, I ran the tests locally as well, using the instructions for Beaker and Docker at https://github.com/voxpupuli/puppet-chrony/blob/679302f6ff7f13a196e26c23492a08259158922c/.github/CONTRIBUTING.md#unit-tests-in-docker . I ran into the issue that the --pidfile-workaround option is presumably meant to solve (with systemd complaining it would not start chronyd because of a symlink issue with the pidfile) when I used the latest CentOS 7 container, but the tests all passed when I used a 7.6 container.

If I'm way off on this or I've done something incorrectly I beg your patience; this is the first time I've done something like this. I would be happy to provide any more information I can or make any needed changes. Thanks!

[jasonknudsen]

+1

[jhunt-steds]

I've updated my PR to use Stdlib::IP::Address per the comments above; the spec tests (bundle exec rake test) pass locally.

[smortex]

Looks great!

[smortex]

@jhunt-steds CI should be fixed in master. Can you please rebase on top of it and force push to update this PR?

[jhunt-steds]

@smortex I hope I've done the right thing here--I don't have much experience with the rebase subcommand.

[smortex]

Weird, your commits appear twice and other commits are listed by GitHub… meh…

Let's fix this :-)

1. Ensure master is up-to-date on your machine:

git checkout master
git pull
git checkout add-bindaddress-config-opt

2. Rebase interactively (-i):

git rebase -i master

This will show up your editor with all commits between master and your current branch, I see all your commits twice:

pick c93e335 add bindaddress option
pick 863c97a change bindaddress type to Stdlib::IP::Address
pick 2168ec3 convert bindaddress to an array
pick 4b09bf5 add bindaddress option
pick 11ef42c change bindaddress type to Stdlib::IP::Address
pick ad414f2 convert bindaddress to an array

Just remove the first 3 lines or the last 3 lines, save and quit. Git will remove these commits from history and the rebase should succeed! If so, then proceed: if you git push -f this PR should only show your 3 commits 🎉

[jhunt-steds]

I followed your instructions exactly. Thanks for the step-by-step guide!

[smortex]

Thanks!

[jhunt-steds]

Thank you!