Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for maxupdateskew #112

Merged
merged 2 commits into from
Jul 4, 2021
Merged

Add support for maxupdateskew #112

merged 2 commits into from
Jul 4, 2021

Conversation

unixsurfer
Copy link
Contributor

Pull Request (PR) description

Adds support for managing maxupdateskew setting.

This Pull Request (PR) fixes the following issues

The aforementioned setting it wasn't managed and as a result users couldn't set a value different from the default one.

@unixsurfer unixsurfer force-pushed the unixsurfer/maxupdateskew branch from 9e6a582 to 8a26db5 Compare June 30, 2021 21:05
@unixsurfer
Copy link
Contributor Author

CI fails for CentOS 7, I am wondering if the chrony version on that distribution supports that parameter. Going to quickly check it out.

@unixsurfer
Copy link
Contributor Author

CI fails for CentOS 7, I am wondering if the chrony version on that distribution supports that parameter. Going to quickly check it out.

Nope, chrony-3.4 version is used which has support for that parameter

@unixsurfer
Copy link
Contributor Author

CI fails for CentOS 7, I am wondering if the chrony version on that distribution supports that parameter. Going to quickly check it out.

Nope, chrony-3.4 version is used which has support for that parameter

The error I see is

Jun 30 21:15:31 centos7-64.example.com chronyd[2287]: Could not open /var/run/chrony/chronyd.pid : Permission denied

and I am not sure if it is caused by this PR.

@smortex
Copy link
Member

smortex commented Jun 30, 2021

Yes, CI is currently broken… Just checked with #114 :-(

smortex
smortex approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@unixsurfer unixsurfer mentioned this pull request Jul 1, 2021
Closed
@smortex smortex added the enhancement New feature or request label Jul 2, 2021
@smortex
Copy link
Member

smortex commented Jul 3, 2021

@unixsurfer CI should be fixed in master. Can you please rebase on top of it and force push to update this PR?

@unixsurfer unixsurfer force-pushed the unixsurfer/maxupdateskew branch from 042d763 to 907dca6 Compare July 4, 2021 06:14
@unixsurfer
Copy link
Contributor Author

@unixsurfer CI should be fixed in master. Can you please rebase on top of it and force push to update this PR?

Done.

@smortex smortex merged commit a53c414 into voxpupuli:master Jul 4, 2021
@unixsurfer unixsurfer deleted the unixsurfer/maxupdateskew branch September 15, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smortex smortex smortex approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unixsurfer @smortex