Allow the password to be a Sensitive string.

[jcpunk]

Pull Request (PR) description

For folks doing mass casting of .password. to Sensitive,
this should help keep chrony working as expected.

This Pull Request (PR) fixes the following issues

N/A

[alexjfisher]

I guess we already use Sensitive here.

puppet-chrony/manifests/config.pp

Line 27 in f53ea01

content => Sensitive(epp($chrony::config_keys_template)),

but this means that we won't store the password as a parameter of the main class in PuppetDB??

[jcpunk]

In theory that should only impact folks who pass in a Sensitive value. Normal strings are still accepted.

[alexjfisher]

But only if you're on Puppet 6.24.0 or later. Before then, unwrap would error if called on a plain String

[alexjfisher]

See puppetlabs/puppet@41991b2

[alexjfisher]

Which is probably fine. But you'd need to update the metadata.json and mark this as breaking. Alternatively, you need to conditionally unwrap the variable depending on its type.

[alexjfisher]

A decision needs to be made about either bumping the minimum puppet version in metadata.json and marking this as breaking, or adding the additional logic so that unwrap isn't called if the data type isn't Sensitive.

[jcpunk]

In theory I've reworked the template to better behavior with older puppet.

I may be missing something on the breaking change part.... as I understand it, unless someone explicitly passes in the argument as Sensitive, the behavior is the same as before.