Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more config settings and prep EL9 support #151

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Add more config settings and prep EL9 support #151

merged 1 commit into from
Aug 2, 2022

Conversation

jcpunk
Copy link
Contributor

@jcpunk jcpunk commented Jun 21, 2022

Pull Request (PR) description

Add new defaults for EL9 and a way to explicitly deny query hosts. Some data constraints and logging options are featured as well.

This Pull Request (PR) fixes the following issues

Replaces: #138
Replaces: #124

stevekay
stevekay reviewed Jun 21, 2022
View reviewed changes
hiera.yaml Outdated Show resolved Hide resolved
vchepkov
vchepkov reviewed Jun 28, 2022
View reviewed changes
data/RedHat.yaml Outdated Show resolved Hide resolved
@jcpunk
Copy link
Contributor Author

jcpunk commented Jul 3, 2022

Given the concerns about leapsectz I've confined the default to EL9. Hopefully this feels safer to merge.

@duritong duritong mentioned this pull request Jul 3, 2022
Closed
@jcpunk
Copy link
Contributor Author

jcpunk commented Jul 5, 2022

I have no idea why these tests are failing.....

@jcpunk jcpunk requested a review from vchepkov July 8, 2022 18:12
@jcpunk
Copy link
Contributor Author

jcpunk commented Jul 12, 2022

Does this look merge-able at this point?

@jcpunk jcpunk requested review from smortex and vchepkov July 13, 2022 18:59
@jcpunk
Copy link
Contributor Author

jcpunk commented Jul 15, 2022

I realized my testing was a bit spotty, so I've updated the tests for more coverage

bastelfreak
bastelfreak reviewed Jul 19, 2022
View reviewed changes
metadata.json Outdated Show resolved Hide resolved
@jcpunk
Copy link
Contributor Author

jcpunk commented Jul 22, 2022

Anyone know why the CI is failing on CentOS9?

@bastelfreak
Copy link
Member

Jul 20 03:27:45 centos9-64.example.com chronyd[57]: Fatal error : Could not open /run/chrony/chronyd.pid : Permission denied

is that maybe the wrong path or wrong user?

@jcpunk
Copy link
Contributor Author

jcpunk commented Jul 25, 2022 •
edited
Loading

It looks like the CentOS Stream 9 container is too minimal for the beaker tests. I'm not sure where the tests are pulling the image from. But for now, I've pulled 9 out of the supported list. I'll see about adding that to my backlog, but for now I'd like to get this merged in without explicit 9 support. It works fine on my actual systems, but the CI is unhappy....

@jcpunk jcpunk changed the title Add more config settings and EL9 support Add more config settings and pre-EL9 support Jul 28, 2022
@jcpunk jcpunk changed the title Add more config settings and pre-EL9 support Add more config settings and prep EL9 support Jul 28, 2022
@jcpunk
Copy link
Contributor Author

jcpunk commented Jul 28, 2022

I've got the PR and commit reworded to clarify the scope of the EL9 work.

I think this is workable to merge, but, given the number of comments, I'd like to make sure everyone's had their feedback addressed.

@jcpunk jcpunk added the enhancement New feature or request label Aug 1, 2022
jhoblitt
jhoblitt approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@jhoblitt jhoblitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I appreciate the conditional blocks in the .epp.

@jhoblitt
Copy link
Member

jhoblitt commented Aug 2, 2022

Side note: It looks like centos 8 is missing from metadata.json, so there are no acceptance tests running for EL8 either.

@jhoblitt jhoblitt merged commit e92ea09 into voxpupuli:master Aug 2, 2022
@jhoblitt
Copy link
Member

jhoblitt commented Aug 2, 2022

I'm requesting that EL8 be added to the acceptance test matrix before a new release is cut.

@jcpunk jcpunk deleted the more-features branch August 2, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekay stevekay stevekay left review comments

@bastelfreak bastelfreak bastelfreak left review comments

@alexjfisher alexjfisher alexjfisher left review comments

@jhoblitt jhoblitt jhoblitt approved these changes

@smortex smortex smortex approved these changes

@vchepkov vchepkov Awaiting requested review from vchepkov

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jcpunk @bastelfreak @jhoblitt @alexjfisher @smortex @vchepkov @stevekay