make config_keys option optional #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
still a draft, but I wanted to have CI. |
Previously we always wrote `keyfile` to the chrony configuration file. This is not always desired. To not cause a breaking change but still make this configureable, the parameter is now a variant. Besides passing an absolute path, you can now set it to `''` (empty string). If that's the case, the keys file won't be managed by Puppet and the option will be removed from the config file.
|
not a draft anymore :) |
sebastianrakel
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we always wrote
keyfileto the chrony configuration file.This is not always desired. To not cause a breaking change but still
make this configureable, the parameter is now a variant. Besides passing
an absolute path, you can now set it to
''(empty string). If that'sthe case, the keys file won't be managed by Puppet and the option will
be removed from the config file.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues