Add stratumweight parameter #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, for RedHat and Debian, the module has `stratumweight` hardcoded to `0`. Chrony's default has been `0.001` since version 2.0 and the default configuration file shipped with EL7 doesn't set it to `0` either. (I suspect a similar situation with modern Debian OSes). The new parameter defaults to `undef` and leaves out explicitly configuring `stratumweight` in the configuration file. This is technically a breaking change as to preserve the old behaviour, it has to be set to `0`. I still think this is preferable to defaulting the parameter to `0` (for OSes other than ArchLinux) and expecting users to know that `0.001` would be a better choice.
alexjfisher
force-pushed
the
stratumweight
branch
from
336e00a to
e304572
Compare
alexjfisher
commented
Dec 5, 2019
| @@ -40,6 +40,7 @@ | |||
| Optional[String] $smoothtime = $chrony::params::smoothtime, | |||
| Optional[Enum['system', 'step', 'slew', 'ignore']] $leapsecmode = $chrony::params::leapsecmode, | |||
| Optional[Float] $maxslewrate = $chrony::params::maxslewrate, | |||
| Optional[Numeric] $stratumweight = $chrony::params::stratumweight, | |||
There was a problem hiding this comment.
Numeric instead of Float to allow 0.
|
@alexjfisher nice work, thanks for this, will cut a new version this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, for RedHat and Debian, the module has
stratumweighthardcoded to
0. Chrony's default has been0.001since version 2.0 andthe default configuration file shipped with EL7 doesn't set it to
0either. (I suspect a similar situation with modern Debian OSes).
The new parameter defaults to
undefand leaves out explicitlyconfiguring
stratumweightin the configuration file.This is technically a breaking change as to preserve the
old behaviour, it has to be set to
0. I still think this ispreferable to defaulting the parameter to
0(for OSes other than ArchLinux)and expecting users to know that
0.001would be a better choice.