Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Arch Linux configuration #77

Merged
merged 2 commits into from
Jul 16, 2020
Merged

Fix Arch Linux configuration #77

merged 2 commits into from
Jul 16, 2020

Conversation

0x6d617474
Copy link
Contributor

The service name chrony in Arch Linux is chronyd, and the package defines a location under /var/lib/chrony for the service to store data instead of /etc.

The module is currently broken for Arch Linux out of the box, running the latest version of chrony from the official repos. These changes will allow new instances to work correctly, and shouldn't have much impact on existing installations.

@ekohl
Copy link
Member

ekohl commented Jul 11, 2020

There is now a merge conflict. Mind rebasing this to fix the merge conflicts?

@chrekh
Copy link
Contributor

chrekh commented Jul 11, 2020

The proposed changes for archlinux is likely still needed. But should now be possible to do in params.pp since the template is changed. And the test for dumpdir when 'Archlinux' context 'using defaults' needs to be changed also.

@0x6d617474
Copy link
Contributor Author

Rebased, updated with passing tests

@chrekh
Copy link
Contributor

chrekh commented Jul 16, 2020

Good. I propose that we merge this before #89 and let me rebase that one.

@ekohl ekohl added bug Something isn't working and removed needs-rebase labels Jul 16, 2020
@ekohl ekohl merged commit 3e9e674 into voxpupuli:master Jul 16, 2020
@0x6d617474 0x6d617474 deleted the fix_arch_service_name branch July 17, 2020 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants