Require Package['corosync'] breaks puppetrun if $package_corosync/pacemaker is set to false

[kskurtveit]

Require Package['corosync']/Package['pacemaker'] breaks puppetrun if $package_corosync/pacemaker is set to false. Not able to use other repo or packages or just to use puppet to create a basic config when $package_corosync/pacemaker is set to false.

[roidelapluie]

Please re-add the dependencies in the form:

if $package_macemaker {
Package['corosync'] -> File [ '/etc/corosync/corosync.conf' ]
}

[kskurtveit]

Show me a slightly bigger example of what you mean and I'll add it for you.

[oranenj]

@kskurtveit: Nothing much bigger to show. For each dependency you remove as a metaparameter, you will need to introduce an explicit dependency using references, guarded by an if like @roidelapluie showed.

So if you have

file { 'bar':
  require => Package['corosync']
}

You'll need to change that to

file {'bar':
}
if $package_corosync {
  Package['corosync'] -> File['bar']
}

[ffrank]

An alternative syntax is

file {'bar':
}
if $package_corosync {
  File['bar'] {
    require => Package['corosync']
  }
}

But the arrow syntax is preferable.

[wyardley]

Would this commit (in the current modulesync branch) resolve the issue? 0d7cfb1
Is anyone interested / willing to fix remaining test failures?

[wyardley]

I think this is fixed in #395, now merged. However, we'll still need to work on #408 and #409 before doing a release.