Define the names of the quorum members #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btravouillon
force-pushed
the
quorum_members_names
branch
from
0271f92 to
2522d96
Compare
wyardley
reviewed
Oct 23, 2017
| @@ -266,6 +271,7 @@ | |||
| $votequorum_expected_votes = $::corosync::params::votequorum_expected_votes, | |||
| $quorum_members = ['localhost'], | |||
| $quorum_members_ids = undef, | |||
| $quorum_members_names = undef, | |||
There was a problem hiding this comment.
Even though we haven't switched to data types yet for the whole module, should probably add this as Optional[Array] $quorum_members_names
wyardley
added
backwards-incompatible
enhancement
btravouillon
force-pushed
the
quorum_members_names
branch
from
2522d96 to
7622ba0
Compare
Persistent names are required when you define IP addesses in quorum_members. Otherwise, crm_node --name-for-id number can't find the name of the member. https://clusterlabs.org/doc/en-US/Pacemaker/1.1/html/Pacemaker_Explained/s-node-name.html
btravouillon
force-pushed
the
quorum_members_names
branch
from
7622ba0 to
45d2304
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Persistent names are required when you define IP addesses in
quorum_members. Otherwise, crm_node --name-for-id number can't find the
name of the member.
https://clusterlabs.org/doc/en-US/Pacemaker/1.1/html/Pacemaker_Explained/s-node-name.html