-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support configuration repositories when using mount #177
Conversation
👍
Having this in the module proper is a good improvement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, I also really like the two improvements (mount_options
as array and deprecation of mount_method
on cvmfs::mount
.
I only added two small nits, but these should not prevent this from being merged 😉 .
This patch only comes into play when using the `mount_method` of `mount` rather than the default autofs. It is now possible to specify that one particular repository on a client is the configuration repository and must be mounted first before all other repositories. This should happen during puppets initial configuration of CvmFS and also at reboot. ```puppet class{'cvmfs': mount_method => 'mount', config_repo => 'cvmfs-config.example.org', } cmvfs::mount{'myrepo.example.org':} cmvfs::mount{'cvmfs-config.example.org':} ``` In this example the repository `cvmfs-config.example.org` will be mounted before `myrepo.example.org`. Note there is all ways at most one configuration repository per client. Fixes: voxpupuli#176
Thanks, that lookgs good to me, nice to finally have all occurrences of CVMFS consistent 👍 . |
Pull Request (PR) description
This patch only comes into play when using the
mount_method
ofmount
rather than the default autofs.It is now possible to specify that one particular repository on a client is the configuration repository and must be mounted first before all other repositories. This should happen during puppets initial configuration of CvmFS and also at reboot.
In this example the repository
cvmfs-config.example.org
will be mounted beforemyrepo.example.org
.Note there is all ways at most one configuration repository per client.
This Pull Request (PR) fixes the following issues
Fixes: #176
In addition a couple of parameters to
cvmfs::mount
are made bettter:mount_method
tocvmfs::mount
never made sense and setting it is pointless unless also set in the main class.deprecate the parameter. It will still be accepted now but is redundant. It was already documented as 'DO NOT SET'.
mount_options
now defaults to an Array of options but a String is still accepted for now.