Allow service to be managed seperately #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,6 +13,7 @@ | |||
| # by cvmfs. If you are managing autofs elsewhere set to false. | |||
| # This being the string 'true' and not boolean true is a hiera bug. | |||
| $config_automaster = hiera('cvmfs_config_automaster','true') | |||
| $manage_autofs_service = hiera('cvmfs_manage_autofs_service','true') | |||
There was a problem hiding this comment.
Please set this just true and skip the explicit hiera call. I plan to deprecate all these hiera calls in favor of parameter lookup.
There was a problem hiding this comment.
Hmmm this is backwards incompatible if someone has set config_automaster false.
In params.pp $manage_autofs_service should default to $cvmfs::config_automaster I think? Not sure if that works.
|
Am fine in principal but would ideally like to make it backwards compatible though it's not obvious |
|
@jcpunk I'm happy to merge this, could you squash the commits and I'll do so. |
traylenator
added a commit
that referenced
this pull request
Apr 29, 2015
Allow autofs service to be managed seperately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20