Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust gpg args to account for slightly different display. #84

Merged
merged 1 commit into from
Jun 14, 2019

Conversation

jadestorm
Copy link

@jadestorm jadestorm commented Jun 4, 2019

This PR updates the gpg call to work with RHEL8. It adds a -q flag to silence a little warning (no big deal) but more importantly, the key went from being displayed like:

pub  4096R/352C64E5 2013-12-16 Fedora EPEL (7) <epel@fedoraproject.org>

to

pub   rsa4096/352C64E5 2013-12-16 [SCE]
         91E.......not typing this out
uid                                       Fedora EPEL (7) <epel@fedoraproject.org>

The PR isolates the pub line, and uses delimiter based cutting to get at the thumbprint we are looking for.

Note: I realize EPEL is not really ready for 8 yet, but I'm currently fudging it a bit by pointing 8 at 7. =)

…how it handles finding the pub signature. Mostly to support RHEL8.
@jadestorm
Copy link
Author

I just noticed that I caused the tests to fail, fixed all that up and trimmed my list of commits to a single one. =)

@rnelson0
Copy link
Member

Validated the CLI argument is present in RHEL 6 and CentOS 7, does anyone have RHEL or CentOS 5 to test with since this module still supports that?

@jadestorm
Copy link
Author

@rnelson0 One of my coworkers surprisingly had a rhel5 box around and was able to confirm that gpg accepts -q. =) Is that the only thing you were concerned about?

@rnelson0
Copy link
Member

Yep, one never knows whether older versions have all the flags and would hate for this to add an error for some users. Also, I weep for your coworker :D

@rnelson0 rnelson0 merged commit 2341f73 into voxpupuli:master Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants