Amazon Linux 2 - bugfix - use enterprise linux 7 #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nehalrp
changed the title
nehalrp
changed the title
nehalrp
force-pushed
the
nehal/fix-amazon-linux-support
branch
from
54b5380
to
8e1c1f8
Compare
nehalrp
force-pushed
the
nehal/fix-amazon-linux-support
branch
from
d1e3547
to
810e597
Compare
nehalrp
force-pushed
the
nehal/fix-amazon-linux-support
branch
from
3cf01a2
to
538acd2
Compare
rnelson0
approved these changes
Feb 6, 2020
|
@nehalrp Thank you for these fixes! |
alexjfisher
reviewed
Mar 28, 2020
| @@ -80,7 +80,7 @@ | |||
| $epel_gpg_managed = $epel::params::epel_gpg_managed, | |||
| $os_maj_release = $epel::params::os_maj_release, | |||
| ) inherits epel::params { | |||
| if "${::osfamily}" == 'RedHat' and "${::operatingsystem}" !~ /Fedora|Amazon/ { # lint:ignore:only_variable_string | |||
There was a problem hiding this comment.
The module now explodes if you try to use it on Fedora instead of hitting the notice ("Your operating system ${::operatingsystem} will not have the EPEL repository applied") line.
This is causing build failures in puppet-letsencrypt.
alexjfisher
added a commit
to alexjfisher/puppet-epel
that referenced
this pull request
Mar 28, 2020
Prior to voxpupuli#95 including `epel` on Fedora was a no-op. This commit restores this behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it would throw a
Cannot find a valid baseurl for repo: epelerror as no mirrorlist nor baseurl would be populated for Amazon; this fixes that with the assumption that Amazon Linux 2 uses Enterprise Linux 7 as per AWS docs:https://aws.amazon.com/premiumsupport/knowledge-center/ec2-enable-epel/