Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency in provisioning plugins #118

Merged
merged 2 commits into from
Jul 3, 2018

Conversation

drshawnkwang
Copy link

@drshawnkwang drshawnkwang commented Jul 3, 2018

Pull Request (PR) description

Add a file resource to config function.
Modified dependency slightly to allow plugins to be installed after file resource creates plugin directory: only works for package, repo, and archive install methods.

This Pull Request (PR) fixes the following issues

Fixes #79

Modified dependency slightly to allow plugins to be installed after file resource creates plugin directory: only works for package, repo, and archive install methods.
@drshawnkwang
Copy link
Author

Tested on Debian 9 stretch with grafana v 5.2.0. Other unit tests should be run as well.

@bastelfreak bastelfreak changed the title Added a file resource to config function. Add a file resource to config function. Jul 3, 2018
@bastelfreak
Copy link
Member

@drshawnkwang thanks for the PR! Can you take a look at the failing spec tests?

@bastelfreak bastelfreak added enhancement New feature or request tests-fail labels Jul 3, 2018
@drshawnkwang
Copy link
Author

drshawnkwang commented Jul 3, 2018

Oops, sorry about the whitespace - the latest commit should fix it..

@drshawnkwang drshawnkwang changed the title Add a file resource to config function. Fix dependency in provisioning plugins Jul 3, 2018
@bastelfreak bastelfreak added bug Something isn't working and removed enhancement New feature or request tests-fail labels Jul 3, 2018
@bastelfreak
Copy link
Member

Thanks!

@bastelfreak bastelfreak merged commit e43d5ef into voxpupuli:master Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grafana plugin install/check breaks catalog run when grafana-server service is not running
2 participants