Replace config template by conversion to yaml #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwaffen
reviewed
Sep 20, 2024
lbetz
force-pushed
the
icingadb-config-file
branch
from
6d1b698 to
c76218c
Compare
ekohl
reviewed
Sep 20, 2024
lbetz
force-pushed
the
icingadb-config-file
branch
from
c76218c to
66712a0
Compare
bastelfreak
reviewed
Sep 23, 2024
| $conf_dir = $icingadb::globals::conf_dir | ||
| $user = $icingadb::globals::user | ||
| $group = $icingadb::globals::group | ||
| $redis_tls_files = $icingadb::redis_tls_files | ||
| $db_tls_files = $icingadb::db_tls_files | ||
| $config_content = if versioncmp($stdlib_version, '9.0.0') < 0 { | ||
| to_yaml($icingadb::config) |
There was a problem hiding this comment.
are there still users for this old version of stdlib? metadata.json lists 9.0.0 als oldest supported version.
There was a problem hiding this comment.
Yes, I have a customer this week who is not on the bleeding edge.
There was a problem hiding this comment.
That's the reason for the other three Icinga modules to also support older version.
There was a problem hiding this comment.
If that version is supported, metadata.json should reflect that
There was a problem hiding this comment.
It does?!
Line 12 in 54fa582
There was a problem hiding this comment.
Sorry, I went @bastelfreak's comment
There was a problem hiding this comment.
@ekohl You're welcome.
ekohl
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.