Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow export clients to be Array #213

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Allow export clients to be Array #213

merged 1 commit into from
Jan 31, 2025

Conversation

moritz-makandra
Copy link
Contributor

Pull Request (PR) description

The clients parameter of nfs::server::export can be an array according to nfs::functions::create_export.

This Pull Request (PR) fixes the following issues

Allow clients to be the same datatype in nfs::server::export and nfs::functions::create_export

kenyon
kenyon requested changes Jan 19, 2025
View reviewed changes
Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REFERENCE.md needs to be regenerated with bundle exec rake strings:generate:reference.

manifests/server/export.pp Outdated Show resolved Hide resolved
kenyon
kenyon approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to also have a test covering this, but it looks like the tests in this module need a lot of work, so let's merge this for now.

@kenyon kenyon merged commit bb4a3e9 into voxpupuli:master Jan 31, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenyon kenyon kenyon approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moritz-makandra @kenyon