Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

puppet-nginx requires outdated module dependencies #1107

Closed
fnoop opened this issue Aug 5, 2017 · 2 comments · Fixed by #1108
Closed

puppet-nginx requires outdated module dependencies #1107

fnoop opened this issue Aug 5, 2017 · 2 comments · Fixed by #1108
Assignees

Comments

@fnoop
Copy link
Contributor

fnoop commented Aug 5, 2017

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 5.0.0
  • Ruby: 2.1.3
  • Distribution: Ubuntu 16.04
  • Module version: 0.7, 0.71rc

How to reproduce (e.g Puppet code you use)

puppet module install puppet-nginx

What are you seeing

Module fails to install with missing dependencies. If I force install, I see:

Warning: Module 'puppetlabs-apt' (v4.1.0) fails to meet some dependencies:
  'puppet-nginx' (v0.7.1-rc0) requires 'puppetlabs-apt' (>= 2.1.0 <3.0.0)
Warning: Module 'puppetlabs-concat' (v4.0.0) fails to meet some dependencies:
  'puppet-nginx' (v0.7.1-rc0) requires 'puppetlabs-concat' (>= 3.0.0 <4.0.0)

The modules I have installed are:
puppetlabs-concat (v4.0.0)
puppetlabs-apt (v4.1.0)

What behaviour did you expect instead

To install cleanly.

@wyardley
Copy link
Collaborator

wyardley commented Aug 7, 2017

@fnoop check out #1106 - the style guide wants apt to be a soft dependency anyway.

I created #1108 which just sets concat to < 5.0.0 instead of <4.0.0; I think the module does work with 4.x, and it was probably specified that way to avoid an error from not having an upper limit on the require?

alexjfisher added a commit that referenced this issue Aug 8, 2017
bump concat to <5.0.0 instead of <4.0.0 (#1107)
@fnoop
Copy link
Contributor Author

fnoop commented Aug 10, 2017

@wyardley @alexjfisher Works great, thanks :)

cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this issue Sep 13, 2019
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this issue Oct 19, 2020
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this issue Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants