Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple parameters for gzip_proxied #1567

Closed
promarcel opened this issue Jul 7, 2023 · 0 comments · Fixed by #1578
Closed

Allow multiple parameters for gzip_proxied #1567

promarcel opened this issue Jul 7, 2023 · 0 comments · Fixed by #1578

Comments

@promarcel
Copy link

promarcel commented Jul 7, 2023

In commit 536e613 (PR #1520) a custom type for the gzip_proxied parameter has been added, which is great to add further validation for inputs.

But due to the official NGINX documentation the parameter gzip_proxied allows multiple parameters (https://nginx.org/en/docs/http/ngx_http_gzip_module.html#gzip_proxied), which is not covered by the current type:

type Nginx::GzipProxied = Enum['off', 'expired', 'no-cache', 'no-store', 'private', 'no_last_modified', 'no_etag', 'auth', 'any']

In detail there is not working an array of options (['expired', 'no-cache', 'no-store', 'private', 'auth']) or a string with multiple parameters ('expired no-cache no-store private auth').

This should not be the expected behavior if the official documentation allows multiple parameters. As a current workaround http_cfg_append can be used to allow configuration of multiple parameters.

jay7x added a commit to jay7x/puppet-nginx that referenced this issue Oct 15, 2023
According to the official NGINX documentation the parameter gzip_proxied
allows multiple parameters.

Closes voxpupuli#1567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants