Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation Error #405

Closed
jg-development opened this issue Aug 15, 2014 · 3 comments
Closed

Documentation Error #405

jg-development opened this issue Aug 15, 2014 · 3 comments

Comments

@jg-development
Copy link
Contributor

Hi,

the actual documentation of the nginx::resource::map define has an error.
The hiera settings are different now. The correct use is "nginx::string_mappings:" and not "nginx::maps". I think it was changed in the past?

Greetings Jan
@3flex
Copy link
Contributor

3flex commented Aug 15, 2014

Hi @jg-development I don't see any example in the README that shows "nginx::maps". Which file do you see this inaccuracy in?

Also if you edit the file and create a pull request to fix it that would be much appreciated.

@jg-development
Copy link
Contributor Author

Hi,

in the "manifests/resource/map.pp" file is a documentation at the beginning.

Greetings Jan

@jg-development
Copy link
Contributor Author

Added Pull Request

@3flex 3flex closed this as completed in 1779d7d Aug 22, 2014
cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this issue Oct 23, 2017
@3flex
Merge pull request voxpupuli#410 from jg-development/master
849b078 
Fixed documentation in resource map

Fixes voxpupuli#405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@3flex @jg-development