-
-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSL Parameter should be configurable outside of vhosts #670
Comments
I think its good to have a set of defaults but i would also like to be able to override this on the vhost |
@b4ldr That should not be an issue. Thus using a wildcard include of conf.d or modules.d or simply placing a global ciphersuite within the http section before including virtual hosts one should have the best of both worlds. |
@omcnet I also think it makes a lot of sense to have SSL defaults on the Please have directives added directly to the nginx.conf file, don't put them into a separate file to include, so the generated configuration is easier to understand. |
I think this is sensible as well, but as best I know, a PR hasn't come up for this, and it's 1 year later. Other than keeping things shorter and more readable, I'd argue that it's more or less a cosmetic thing, since the current solution should give the same results. But I'm going to leave this open, since I would love to see this get implemented if it's not too difficult. We'd probably need to move some of the default parameters out of the 'vhost' resource and into params or config? |
…x_conf Add ability to set ssl-settings globally - fixes #670
…s_to_nginx_conf Add ability to set ssl-settings globally - fixes voxpupuli#670
It may be common practice, but there is no point in configuring the ssl parameters in every vhosts.
There should be a global configuration that sets secure defaults and only if a vhosts really needs a custom config, should the vhost parameters be used.
This would make all vhosts more readable, mass updates more stable and analysis of the configuration by admins much easier.
This seems even more important since the default value is a very verbose way of naming the currently mostly used ciphers.
What does @jfryman think about this? If you can confirm that this would be helpful, i could work on a PR to implement this. But if this is not desired I will stick with a fork.
Another alternative would to be to handle an undef or empty value of ciphers and handling that case by not adding a configuration line.
The text was updated successfully, but these errors were encountered: