Suffix timeout values with second indicator #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolution for issue 1137
ekohl
approved these changes
Oct 27, 2017
alexjfisher
added
bug
|
According to the docs, this shouldn't be necessary, but it is recommended.
|
|
That is odd, because this change does actually resolve our timeout issues. Perhaps there is a bug in nginx somewhere that causes one of these values to be parsed incorrectly without a suffix. |
alexjfisher
approved these changes
Oct 27, 2017
|
I agree that it should be valid to not include the units, though I'm still +1 on the change. I did see something where our old code didn't work anymore w/ the new version of this module that some of these types should maybe support either string or integer. |
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
…ndspatch Suffix timeout values with second indicator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolution for issue 1137:
Issue 1137