Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start one worker process per core #1238

Merged
merged 1 commit into from
Oct 6, 2018
Merged

start one worker process per core #1238

merged 1 commit into from
Oct 6, 2018

Conversation

bastelfreak
Copy link
Member

Many people are confused by this default setting. The default of one
core is often a bottleneck. I would like to switch the default to the
amount of cores.

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@bastelfreak bastelfreak added the enhancement New feature or request label Aug 9, 2018
@ekohl
Copy link
Member

ekohl commented Aug 10, 2018

Acceptance tests are very unhappy for unrelated reasons

@alexjfisher
Copy link
Member

IMO, this is a 'breaking change'. Even though they recommend 'auto', the upstream nginx default is still 1. The change would at the very least need clearly documenting in the README.

Perhaps we should actually allow and default to undef and not write anything into nginx.conf (so that it
implicitly uses the default). That way, we wouldn't have to make any changes if they decide to change it.

@alexjfisher alexjfisher added the needs-feedback Further information is requested label Aug 10, 2018
@baurmatt
Copy link
Contributor

For us, its totally valid to default to auto an mention this in the README as this is the recommended setting. But this is probably a larger discussion: Are Puppet module in general supposed to roll out:

  1. The default of the software
  2. The default of the OS package
  3. Sane defaults known to be best practices

We always tend to 2. or 3. because 1. is for the majority of software not really usable in the real world.

@bastelfreak
Copy link
Member Author

I think switching to auto would be the best approach.

ekohl
ekohl approved these changes Oct 1, 2018
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is a sane update.

@ekohl
Copy link
Member

ekohl commented Oct 1, 2018

Btw, please do fix the tests before merging :)

@ekohl ekohl mentioned this pull request Oct 6, 2018
Merged
@bastelfreak
start one worker process per core
cd74eac 
Many people are confused by this default setting. The default of one
core is often a bottleneck. I would like to switch the default to the
amount of cores. The auto option is also recommended upstream:
https://www.nginx.com/blog/tuning-nginx/
@bastelfreak bastelfreak merged commit 6ff9bf1 into voxpupuli:master Oct 6, 2018
@bastelfreak bastelfreak deleted the cores branch October 6, 2018 21:29
@ekohl ekohl removed the needs-feedback Further information is requested label Oct 6, 2018
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this pull request Oct 19, 2020
@bastelfreak
Merge pull request voxpupuli#1238 from bastelfreak/cores
1d1eac9 
start one worker process per core
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhollinger dhollinger dhollinger approved these changes

@ekohl ekohl ekohl approved these changes

@hunner hunner Awaiting requested review from hunner

@eputnam eputnam Awaiting requested review from eputnam

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bastelfreak @ekohl @alexjfisher @baurmatt @dhollinger