Propery handle ${client_body,proxy}_temp_path #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The template already allowed setting it to false. This completes it.
Closed
ekohl
commented
Oct 1, 2018
| @@ -26,7 +26,7 @@ | |||
| # } | |||
| class nginx ( | |||
| ### START Nginx Configuration ### | |||
| $client_body_temp_path = $nginx::params::client_body_temp_path, | |||
| Variant[Stdlib::Absolutepath, Boolean] $client_body_temp_path = $nginx::params::client_body_temp_path, | |||
There was a problem hiding this comment.
I wasn't sure about a boolean false here or an empty string. Thoughts?
There was a problem hiding this comment.
I think Boolean is better than empty string and it's probably not worth making it a breaking change by defaulting to undef and making it Optional.
There was a problem hiding this comment.
It does mean that true is allowed but not really handled - OTOH, it wasn't either in the past
alexjfisher
approved these changes
Oct 1, 2018
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Sep 13, 2019
Propery handle ${client_body,proxy}_temp_path
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Propery handle ${client_body,proxy}_temp_path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template already allowed setting it to false. This completes it.