Mock facter version based on puppet version & unit tests: print puppet/facter version #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Oct 31, 2019
| @@ -42,6 +42,18 @@ | |||
| end | |||
|
|
|||
| RSpec.configure do |c| | |||
| # getting the correct facter version is tricky. We use facterdb as a source to mock facts | |||
There was a problem hiding this comment.
Are you going to submit this to modulesync as well?
There was a problem hiding this comment.
Of course. I just need to test it here.
bastelfreak
added a commit
to bastelfreak/modulesync_config
that referenced
this pull request
Nov 1, 2019
Getting the correct facter version is tricky. We use facterdb as a source to mock facts see https://github.com/camptocamp/facterdb. People might provide a specific facter version. In that case we use it. Otherwise we need to match the correct facter version to the used puppet version. As of 2019-10-31, puppet 5 ships facter 3.11 and puppet 6 ships facter 3.14 (see https://puppet.com/docs/puppet/5.5/about_agent.html). This was tested at voxpupuli/puppet-nginx#1355
DavidS
reviewed
Nov 1, 2019
alexjfisher
reviewed
Nov 1, 2019
| c.default_facter_version = if ENV['FACTERDB_FACTS_VERSION'] | ||
| ENV['FACTERDB_FACTS_VERSION'] | ||
| else | ||
| Gem::Dependency.new('', ENV['PUPPET_VERSION']).match?('', '5') ? '3.11.0' : '3.14.0' |
There was a problem hiding this comment.
In theory, 3.11 and 3.14 (without the .0) would work now. But that's not important.
alexjfisher
approved these changes
Nov 1, 2019
zachfi
pushed a commit
to zachfi/modulesync_config
that referenced
this pull request
Feb 5, 2020
Getting the correct facter version is tricky. We use facterdb as a source to mock facts see https://github.com/camptocamp/facterdb. People might provide a specific facter version. In that case we use it. Otherwise we need to match the correct facter version to the used puppet version. As of 2019-10-31, puppet 5 ships facter 3.11 and puppet 6 ships facter 3.14 (see https://puppet.com/docs/puppet/5.5/about_agent.html). This was tested at voxpupuli/puppet-nginx#1355
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Mock facter version based on puppet version & unit tests: print puppet/facter version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting the correct facter version is tricky. We use facterdb as a source to mock facts see https://github.com/camptocamp/facterdb. People might provide a specific facter version. In that case we use it. Otherwise we need to match the correct facter version to the used puppet version. As of 2019-10-31, puppet 5 ships facter 3.11 and puppet 6 ships facter 3.14 (see https://puppet.com/docs/puppet/5.5/about_agent.html).