Add support for limit_req_zone in main nginx config and limit_req: Fixes #1134 #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for `limit_req_zone` in main nginx config and `limit_req` for `nginx::resource::location`. In init.pp `limit_req_zone` can be a String, or an array of String In resource/location.pp `limit_zone` can be a String and should point to a zone defined from `limit_req_zone` in init.pp
absltkaos
changed the title
bastelfreak
reviewed
Nov 16, 2019
bastelfreak
reviewed
Nov 16, 2019
|
Hi @absltkaos, thanks for the PR. can you add some unit tests for it? |
Co-Authored-By: Tim Meusel <tim@bastelfreak.de>
Co-Authored-By: Tim Meusel <tim@bastelfreak.de>
I'm not super familiar with Rspec, but I'll see what I can do. |
|
thanks! |
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Add support for limit_req_zone in main nginx config and limit_req: Fixes voxpupuli#1134
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
limit_req_zonein main nginx config andlimit_reqfor
nginx::resource::location.In init.pp
limit_req_zonecan be a String, or an array of StringIn resource/location.pp
limit_zonecan be a String and should point to a zone defined fromlimit_req_zonein init.ppPull Request (PR) description
This Pull Request (PR) fixes the following issues