Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensured file mode permissions are more consistent #1393

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

triforce
Copy link
Contributor

Pull Request (PR) description

Changed the 'file' resources mode to use $nginx::global_mode to keep permissions consistent and secure

This Pull Request (PR) fixes the following issues

n/a

@puppet-community-rangefinder
Copy link

nginx::resource::geo is a type

that may have no external impact to Forge modules.

nginx::resource::location is a type

Breaking changes to this file WILL impact these 8 modules (exact match):
Breaking changes to this file MAY impact these 15 modules (near match):

nginx::resource::mailhost is a type

that may have no external impact to Forge modules.

nginx::resource::map is a type

that may have no external impact to Forge modules.

nginx::resource::server is a type

Breaking changes to this file WILL impact these 10 modules (exact match):
Breaking changes to this file MAY impact these 2 modules (near match):

nginx::resource::upstream is a type

Breaking changes to this file WILL impact these 1 modules (exact match):
Breaking changes to this file MAY impact these 13 modules (near match):

This module is declared in 11 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ekohl
Copy link
Member

ekohl commented Jun 30, 2020

EL7 failure is due to the GPG key on the passenger repos.

@ekohl ekohl merged commit e4ba3e0 into voxpupuli:master Jun 30, 2020
@ekohl ekohl added the enhancement New feature or request label Jun 30, 2020
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this pull request Oct 19, 2020
…l_files

Ensured file mode permissions are more consistent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants