Add two more data types to streamhost.pp #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
approved these changes
Aug 29, 2020
alexjfisher
commented
Aug 29, 2020
manifests/resource/streamhost.pp
Outdated
| String $proxy_read_timeout = $nginx::proxy_read_timeout, | ||
| $proxy_connect_timeout = $nginx::proxy_connect_timeout, | ||
| Array $resolver = [], | ||
| Variant[Array[String], String], $raw_prepend = [], |
There was a problem hiding this comment.
oops. How did that extra comma get there?
Data types have been added to `raw_prepend` and `raw_append`. The docs say strings or arrays of strings. Defaults have been changed from `undef` to `[]`. The tempate casts using `Array($raw_prepend)`. Previously, (when the default was `undef`), the template would cast `nil` into an empty array.
alexjfisher
force-pushed
the
more_data_types
branch
from
3e8b2fe
to
45674d2
Compare
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Add two more data types to streamhost.pp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data types have been added to
raw_prependandraw_append.The docs say strings or arrays of strings.
Defaults have been changed from
undefto[].The tempate casts using
Array($raw_prepend).Previously, (when the default was
undef), the template would castnilinto an empty array.