Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to remove some File defaults #1410

Merged
merged 1 commit into from
Aug 29, 2020

Conversation

alexjfisher
Copy link
Member

Resource defaults outside of site.pp are not recommended.
https://puppet.com/docs/puppet/6.18/lang_defaults.html

In these cases, there was only a single file resource in each manifest.

Resource defaults outside of site.pp are not recommended.
https://puppet.com/docs/puppet/6.18/lang_defaults.html

In these cases, there was only a single file resource in each manifest.
@puppet-community-rangefinder
Copy link

nginx::resource::geo is a type

that may have no external impact to Forge modules.

nginx::resource::map is a type

that may have no external impact to Forge modules.

nginx::resource::streamhost is a type

that may have no external impact to Forge modules.

This module is declared in 10 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

content => template('nginx/conf.d/map.erb'),
notify => Class['nginx::service'],
require => File[$conf_dir],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be autorequired.

@alexjfisher alexjfisher merged commit d3fc398 into voxpupuli:master Aug 29, 2020
@alexjfisher alexjfisher deleted the remove_some_file_defaults branch August 29, 2020 17:28
@igalic
Copy link
Contributor

igalic commented Aug 30, 2020

Resource defaults outside of site.pp are not recommended.
https://puppet.com/docs/puppet/6.18/lang_defaults.html

from that document:

Therefore, they not be set outside of site.pp. Use per-resource default attributes when possible.

That document sounds like it needs a fix

Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this pull request Oct 19, 2020
…efaults

Refactor to remove some `File` defaults
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants