implement config check on config change before service restart #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nginx::config is a classBreaking changes to this file MAY impact these 2 modules (near match):nginx is a classBreaking changes to this file WILL impact these 13 modules (exact match):Breaking changes to this file MAY impact these 33 modules (near match):
nginx::resource::geo is a typethat may have no external impact to Forge modules. nginx::resource::location is a typeBreaking changes to this file WILL impact these 8 modules (exact match):Breaking changes to this file MAY impact these 15 modules (near match):nginx::resource::mailhost is a typethat may have no external impact to Forge modules. nginx::resource::map is a typethat may have no external impact to Forge modules. nginx::resource::server is a typeBreaking changes to this file WILL impact these 11 modules (exact match):Breaking changes to this file MAY impact these 3 modules (near match):nginx::resource::snippet is a typethat may have no external impact to Forge modules. nginx::resource::streamhost is a typethat may have no external impact to Forge modules. nginx::resource::upstream is a typeBreaking changes to this file WILL impact these 2 modules (exact match):Breaking changes to this file MAY impact these 14 modules (near match):nginx::service is a classBreaking changes to this file MAY impact these 1 modules (near match):This module is declared in 9 of 575 indexed public
|
|
hey @crazymind1337, thanks for the PR! can you add an acceptance test that sets this and also fix the puppet-lint warning? |
bastelfreak
reviewed
Oct 28, 2020
crazymind1337
force-pushed
the
feature/config_check
branch
from
5f768e9
to
9e78ef0
Compare
crazymind1337
force-pushed
the
feature/config_check
branch
from
9e78ef0
to
43a0547
Compare
bastelfreak
approved these changes
Oct 30, 2020
|
Tests passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This implements a switch to enable the nginx config check via
nginx -ton all config file changes. If the config check is enabled (disabled by default) and fails, the service refresh of nginx will be unscheduled b puppet.This Pull Request (PR) fixes the following issues
No issue created, started directly with the feature.