makes service_config_check exec command configurable

[saz]

Pull Request (PR) description

Right now, the service_config_check exec command is using nginx -t and there's no way to change it.
If you're running e.g. openresty, there's no nginx executable and the check will fail.

This PR adds a paramter $nginx::service_config_check_command with a default value of nginx -t

[puppet-community-rangefinder]

nginx is a class

Breaking changes to this file WILL impact these 14 modules (exact match):

• landcareresearch-ckan
• covata-safeshare
• othalla-nextcloud
• geoffwilliams-r_profile
• pgassmann-letsencrypt_nginx
• samuelson-custom_webapp
• dhollinger-devopsdays
• kalfa-sites
• eelcomaljaars-friendica
• jonhallettuob-existdb
• ploperations-webhook_proxy
• cristifalcas-kibana
• akisakye-matomo
• stackstorm-st2

Breaking changes to this file MAY impact these 34 modules (near match):

• nicopaez-triage
• puppetfinland-patchwork
• ramiel-owncloud
• qtechnologies-psgi
• chedi-django
• groupbuddies-gb
• pltraining-selfpaced
• nicopaez-dockerserver
• braiins-wordpressnginx
• oris-appserver
• puppetfinland-freight
• mtulio-profiles
• maestrodev-maestro_nodes
• 4n0m4l0u5-configure_nginx
• mightp-librenms
• tracywebtech-appdeploy
• dmexe-deploy
• lboynton-gitlab
• aursu-grayloginstall
• compass-learninglocker
• danieldreier-puppet_installer
• klynton-testing
• jbussdieker-graphite_web
• vormetriclabs-meteor
• SchnWalter-happydev
• nicopaez-alfred
• adcade-statsd
• vshn-uhosting
• compass-examdb
• firm1-zds
• ploperations-puppet
• jmkeyes-netbox
• halyard-boxen
• qroac-isp3node

nginx::service is a class

Breaking changes to this file MAY impact these 1 modules (near match):

• rhoml-threescale

This module is declared in 9 of 576 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[saz]

@ekohl Mind taking a look at this? As you've commented on my last PR related to that topic.

[ekohl]

I'd appreciate a puppet-strings parameter documentation. While most parameters are missing, let's try to add them for any new ones. Code wise 👍

[saz]

@ekohl Good point, added.

[ekohl]

Thanks!