Add EL 8/9 to supported OS #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nginx::package::redhat is a classthat may have no external impact to Forge modules. nginx::params is a classBreaking changes to this file WILL impact these 1 modules (exact match):Breaking changes to this file MAY impact these 1 modules (near match):This module is declared in 9 of 580 indexed public
|
bastelfreak
changed the title
smortex
approved these changes
Apr 2, 2023
| @@ -10,12 +10,10 @@ | |||
| pkg_cmd = 'yum info nginx | grep "^From repo"' | |||
| pkg_remove_cmd = 'yum -y remove nginx nginx-filesystem passenger' | |||
| pkg_match = case fact('operatingsystemmajrelease') | |||
| when '8' | |||
| test_passenger = false | |||
| when '7' # https://blog.phusion.nl/2020/05/29/passenger-6-0-5/ | |||
There was a problem hiding this comment.
Hum, this release note says they added support for CentOS/RHEL 8. I guess we can have CI that test passenger on at least RHEL 8, but probably more changes are needed and that is another story for another PR..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues