-
-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multiple limit_req
statements in location
directives
#1570
Conversation
Can someone look at this PR, please? I have no idea why the checks are not successful; I'm a sporadic contributor with correspondingly sparse knowledge of how to pursue this - but the improvement is both trivial and useful (to us, posisbly others). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI fails because of (hard to see in the output):
REFERENCE.md is outdated
Please update REFERENCE.md with
$ bundle exec rake strings:generate:reference
Add it to the PR and CI should continue.
Doing this changes nothing..? I have never used bundle or any of these tools, so I feel extremely noob right now.. |
Dum-did-um @smortex any ideas? :) |
Please update REFERENCE.md with: $ bundle exec rake strings:generate:reference Add it to the PR and CI should continue. |
7afecf5
to
6d95b4e
Compare
I updated |
6d95b4e
to
c525a33
Compare
The unit test needs some work still. |
What kind of work? Anything I can/should do? |
@ltning yes, see the test failure. Something about the matching isn't right. |
Co-authored-by: Romain Tartière <romain@blogreen.org>
Sorry @smortex - I don't understand what's still failing here. I see it passing on most, but not all, test runs. |
limit_req
statements in location
directives
Pull Request (PR) description
Adds support for multiple
limit_req
statements in alocation
by allowinglimit_zone
to be passed as an array OR a string.This Pull Request (PR) fixes the following issues
Fixes #1569