Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy top-scope syntax #1584

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

smortex
Copy link
Member

@smortex smortex commented Nov 23, 2023

No description provided.

@smortex smortex self-assigned this Nov 23, 2023
@smortex smortex marked this pull request as ready for review November 24, 2023 01:26
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about updating the changelog, but otherwise 👍

@TheMeier
Copy link
Contributor

TheMeier commented Jun 2, 2024

@smortex can you re-run the tests?

@TheMeier
Copy link
Contributor

TheMeier commented Jun 2, 2024

Nevermind. The tests will be fixed in #1596. To do so I need someone to approve #1595

@TheMeier TheMeier added this to the 6.0.0 milestone Jun 2, 2024
@TheMeier TheMeier force-pushed the remove-legacy-top-scope-syntax branch from 7299d4a to edadf13 Compare June 5, 2024 08:38
@TheMeier
Copy link
Contributor

TheMeier commented Jun 5, 2024

rebased

@TheMeier TheMeier merged commit 417c599 into master Jun 5, 2024
21 checks passed
@TheMeier TheMeier deleted the remove-legacy-top-scope-syntax branch June 5, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants