Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raise default version to 1.16.0 #1598

Merged
merged 1 commit into from
Jun 5, 2024
Merged

raise default version to 1.16.0 #1598

merged 1 commit into from
Jun 5, 2024

Commits on Jun 3, 2024

  1. raise default version to 1.16.0 

    this fixes the acceptance tests. But there is a bigger issue here.
The code in manifests/init.pp is not idempotent:
```
 String[1] $nginx_version                                = pick(fact('nginx_version'), '1.6.0'),
```
Turns out on the first run the fact might not be set yet leading to a pre 1.15.0 compatible
configuration on systems wich ship a newer version of nginx. Leading to
```
nginx: [emerg] unknown directive "ssl" in /etc/nginx/sites-enabled/www.puppetlabs.com.conf:25
```
    Christoph Maser committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    ab2fde9 View commit details
    Browse the repository at this point in the history