index_files to be defined at server level if specified in resource::vhost #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…host This partially avoids pitfall voxpupuli#2 (http://wiki.nginx.org/Pitfalls)
| @@ -31,6 +31,9 @@ server { | |||
| return 301 https://$host$request_uri; | |||
| } | |||
| <% end -%> | |||
| <% if @index_files -%> | |||
| index <% @index_files.each do |i| %> <%= i %><% end %>; | |||
There was a problem hiding this comment.
What if this isn't an array? Can you cast it as such using Array()?
There was a problem hiding this comment.
I was going off the vhost_location_directory.erb implementation so all fixed now.
|
Sweeeeet! |
jfryman
pushed a commit
that referenced
this pull request
Dec 19, 2013
index_files to be defined at server level if specified in resource::vhost
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Oct 23, 2017
…level index_files to be defined at server level if specified in resource::vhost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially avoids pitfall #2 (http://wiki.nginx.org/Pitfalls)
Perhaps this should only go there if specified by the user than because of the default index_files value? Thoughts welcome?